Global variables override by buffer variables (#80)#137
Open
rockandska wants to merge 4 commits into
Open
Conversation
alerque
requested changes
Feb 21, 2023
Member
alerque
left a comment
There was a problem hiding this comment.
It looks like this covers some of the same ground as #68 (to address
#61) but covers other areas as well and with a different solution.
I'm fine with working with one or both of these PRs to get them mergable.
Buffer local overrides are a good thing in my book as long as global
defaults are honored first.
That being said this will need some merge conflict resolution or rebasing
now. Any chance you are still around to handle that?
Author
|
Will try to resolve merge conflicts soon |
alerque
reviewed
Feb 22, 2023
Relay only on indent_guides_enable_on_vim_startup
de15457 to
6efa633
Compare
Author
|
Rebased and fix applied |
6efa633 to
22157bf
Compare
alerque
approved these changes
Mar 1, 2023
Co-authored-by: Caleb Maclennan <caleb@alerque.com>
6a01f3e to
30ce443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Not a vim expert but seems to do the job requested by #80 and had personally the same needs.
It should allow users to be able to :
For example, if you want :
If you want enable indent-guides for all filetype / buffers except for sh filetype
Comments / suggestions welcome
Edit: update example to reflect new commit